Also copy ruleset when copying falco source

[mstemm]

In the copy constructor and assignment operator for falco_source, also copy the ruleset along with factories/name.

Signed-off-by: Mark Stemm [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ensure that a ruleset object is copied properly in falco_engine::add_source().

[mstemm]

@jasondellaluce -- I noticed a crash in falco_engine::complete_rule_loading (https://github.com/falcosecurity/falco/blob/master/userspace/engine/falco_engine.cpp#L544) when loading rules files and tracked it down to this bug.

I'm confused on how rules loading would work without this fix though. Seems like the (NULL) ruleset would be dereferenced all the time, wouldn't it?

[mstemm]

I understand why falco itself is okay, the ruleset for the source is created from the factory in load_rules(): https://github.com/falcosecurity/falco/blob/master/userspace/engine/falco_engine.cpp#L194. A ruleset for the source is also created in add_source: https://github.com/falcosecurity/falco/blob/master/userspace/engine/falco_engine.cpp#L406, but that one is not copied properly.

I think this crash can only occur if you call complete_rule_loading without ever calling load_rules(). So not a real problem, but would still be a good corner case to fix.

[jasondellaluce]

/milestone 0.34.0

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: 16b859fa2bf399788877da8c0dd76bf15d349eec

[jasondellaluce]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP,jasondellaluce,mstemm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment