Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install ca-certificates in falco:no-driver image #2355

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

Issif
Copy link
Member

@Issif Issif commented Jan 13, 2023

Signed-off-by: Thomas Labarussias [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This PR installs the package ca-certificates in the no-driver image.

Which issue(s) this PR fixes:

Some plugins are calling external API (Okta, EKS, ...) and the requests failed because of missing certificates in the image ssl store:

Error: WebIdentityErr: failed to retrieve credentials
caused by: RequestError: send request failed
caused by: Post "https://sts.us-east-2.amazonaws.com/": x509: certificate signed by unknown authority

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

no

Install the certificates of authorities in falco:no-driver docker image

@FedeDP
Copy link
Contributor

FedeDP commented Jan 13, 2023

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Jan 13, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 13, 2023

LGTM label has been added.

Git tree hash: d6215b5b6ae8b1ae1bc17b7511a8925797bc5d9c

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, Issif, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants