Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake)!: deprecate /etc/falco/rules.available #2389

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 30, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.34.0

Does this PR introduce a user-facing change?:

build: `/etc/falco/rules.available` has been deprecated
build: `application_rules.yaml` is not shipped anymore with Falco
BREAKING CHANGE: if you relied upon `application_rules.yaml` you can download it from https://github.com/falcosecurity/rules/tree/main/rules and manually install it.

…application_rules.yaml` any more

Signed-off-by: Leonardo Grasso <[email protected]>
@poiana poiana added this to the 0.34.0 milestone Jan 30, 2023
@poiana poiana requested review from Kaizhe and mstemm January 30, 2023 11:29
@leogr leogr changed the title build(cmake): deprecate /etc/falco/rules.available and don't ship `… build(cmake): deprecate /etc/falco/rules.available Jan 30, 2023
FedeDP
FedeDP previously approved these changes Jan 30, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Andreagit97 Andreagit97 changed the title build(cmake): deprecate /etc/falco/rules.available build(cmake)!: deprecate /etc/falco/rules.available Jan 30, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1d99e3d into master Jan 30, 2023
@poiana poiana deleted the build/remove-rules-available branch January 30, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants