Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove Mesos support from Falco. #2465

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 3, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This follows up #2328 add deprecation warning for Mesos and completely removes the Mesos support from Falco.

/milestone 0.35.0

Does this PR introduce a user-facing change?:

update!: remove `--mesos-api`, `-pmesos`, and `-pm` command-line flags
BREAKING CHANGE: support for metadata enrichment from Mesos has been removed.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we also have rules mentioning mesos: https://github.com/falcosecurity/rules/blob/main/rules/falco_rules.yaml#L1730
Are we going to clean them up too?

Btw thank you!
/approve

@leogr
Copy link
Member Author

leogr commented Apr 3, 2023

I noticed that we also have rules mentioning mesos: https://github.com/falcosecurity/rules/blob/main/rules/falco_rules.yaml#L1730 Are we going to clean them up too?

Btw thank you! /approve

I will take a look. Though, in that case, it seems to be legit (it refers to Mesos, the application, not our fields)

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 88b9537 into master Apr 4, 2023
@poiana poiana deleted the cleanup/remove-mesos branch April 4, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants