falco-driver-loader add TMPDIR support #2518
Conversation
Closes 2517 Make wrapper now uses $TMPDIR if set. Signed-off-by: jabdr <[email protected]>
|
Welcome @jabdr! It looks like this is your first PR to falcosecurity/falco 🎉 |
poiana
added
size/S
release-note
and removed
do-not-merge/release-note-label-needed
labels
scripts/falco-driver-loader
Outdated
| @@ -252,6 +252,7 @@ load_kernel_module_compile() { | |||
| fi | |||
|
|
|||
| # Try to compile using all the available gcc versions | |||
| MAKEWRAPPER="${TMPDIR:-"/tmp"}/falco-dkms-make" | |||
There was a problem hiding this comment.
I'd move the TMPDIR declaration below, beside other variables declarations near the end of script.
Then, i'd avoid using the MAKEWRAPPER and instead just go with $TMPDIR/falco-dkms-make.
|
Thanks for this! I think it is a valuable fix indeed! |
|
@FedeDP I can change that. Alternatively I could also switch to use mktemp. It uses $TMPDIR if set or else uses /tmp. What do you think? |
I'd go with the simplest solution possible (ie: without involving mktemp) so that we keep a well-known name. |
Signed-off-by: jabdr <[email protected]>
Signed-off-by: jabdr <[email protected]>
|
@FedeDP Done. |
|
LGTM label has been added. Git tree hash: 32cf48fdc2dbc1884019857a1101955fb9580490
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jabdr, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes 2517
Make wrapper now uses $TMPDIR if set.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Replaces hardcoded path for make wrapper, to allow building via falco-driver-loader on systems, where /tmp is mounted with noexec.
Which issue(s) this PR fixes:
Fixes #2517
Special notes for your reviewer:
Does this PR introduce a user-facing change?: