Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): correctly tag slim manifest #2545

Merged
merged 1 commit into from
May 12, 2023
Merged

fix(ci): correctly tag slim manifest #2545

merged 1 commit into from
May 12, 2023

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

/kind bug
/area CI

What this PR does / why we need it:

The right command for crane was copy, not tag in that case

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 12, 2023

LGTM label has been added.

Git tree hash: be7df93587041aa9b08075227919f69e6915b5ee

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented May 12, 2023

Refs #2501
/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 12, 2023
@poiana poiana merged commit 60a006f into master May 12, 2023
@poiana poiana deleted the LucaGuerra-patch-1 branch May 12, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants