feat: add jq and curl to falco-no-driver docker image #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To supoprt the use of outputs that are documented in the falco examples (e.g. jq piped to curl) I would like to propose including these tools in the falco-no-driver image. They add a very minimal size and dependency to the image but would make things a lot easier for users getting started. Closes falcosecurity#2580 Signed-off-by: Daniel Wright <[email protected]>
|
/milestone 0.36.0 cc @LucaGuerra |
|
As discussed privately with some maintainers, and since this change is minimal, we believe it worth including this PR in |
leogr
approved these changes
May 31, 2023
|
LGTM label has been added. Git tree hash: 2761a5ce0bb0c438efc555c4c105d40c65fdf8ad
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, therealdwright The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To supoprt the use of outputs that are documented in the falco
examples (e.g. jq piped to curl) I would like to propose including
these tools in the falco-no-driver image. They add a very minimal
size and dependency to the image but would make things a lot easier
for users getting started.
Closes #2580
Signed-off-by: Daniel Wright [email protected]
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
/area ci
What this PR does / why we need it:
This PR adds the jq and curl packages to the falco-no-driver
Docker image. This will allow users who choose to use this
image to get up and running more quickly with the examples
listed in the documentation for outputs, such as the program
output.
Which issue(s) this PR fixes:
Fixes #2580
Does this PR introduce a user-facing change?:
Adds the curl and jq packages to the falco-no-driver docker image