Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump plugin versions #2610

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Jun 5, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(cmake): bump plugins to latest versions

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update hashes too! :)

@FedeDP
Copy link
Contributor

FedeDP commented Jun 5, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Jun 5, 2023
@loresuso
Copy link
Member Author

loresuso commented Jun 5, 2023

Yeah ofc, I was just waiting :)

@loresuso loresuso force-pushed the update/bump-plugins branch from 1c0ca7c to eeaec58 Compare June 5, 2023 11:00
@poiana poiana added size/S and removed size/XS labels Jun 5, 2023
@loresuso loresuso force-pushed the update/bump-plugins branch from eeaec58 to fbb086a Compare June 5, 2023 11:04
FedeDP
FedeDP previously approved these changes Jun 5, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 5, 2023

LGTM label has been added.

Git tree hash: ae9bc13bccf1114710ff107f74ef482201136e8e

@poiana poiana added the approved label Jun 5, 2023
@jasondellaluce
Copy link
Contributor

At line 17:

set(PLUGINS_DOWNLOAD_BUCKET "dev")

Should be set to "stable".

@loresuso loresuso force-pushed the update/bump-plugins branch from fbb086a to 0339523 Compare June 5, 2023 11:59
@poiana poiana removed the lgtm label Jun 5, 2023
@poiana poiana requested a review from FedeDP June 5, 2023 11:59
@loresuso loresuso force-pushed the update/bump-plugins branch from 0339523 to a982ff3 Compare June 5, 2023 12:08
@poiana
Copy link
Contributor

poiana commented Jun 5, 2023

LGTM label has been added.

Git tree hash: fc2ebff03b6436d601f6fe3521e3ceda18449eb0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 448b972 into falcosecurity:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants