-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(userspace/outputs_http): Add option for mTLS #2633
Conversation
Welcome @annadorottya! It looks like this is your first PR to falcosecurity/falco 🎉 |
cc @alacuku |
/milestone 0.36.0 |
This seems very useful, are we on track to allocate time for review and feature finalization? Thank you! @leogr? |
I agree this is useful. I believe we are still in time. Let's try to merge this for Falco 0.36. |
I've tested it and it works, thank you for this! @annadorottya Could you rebase on master please? |
LGTM label has been added. Git tree hash: 7903895bbe2dce8dbb042516d8f705665a24e562
|
Signed-off-by: Anna Simon <[email protected]>
Sorry I accidentally merged the master branch into my branch, which removed the lgtm and approved labels, can you approve again @leogr ? 🙇 |
No worries even with a direct rebase all previous approvals are removed. Leo and Andrea will approve tomorrow Europe time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you!
LGTM label has been added. Git tree hash: bfbf0dcf5fb2b62eb67aabb9dbd79efde8304ef3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, annadorottya, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it: Currently there is no mTLS option for the HTTP output, it would be more secure to have this feature.
Which issue(s) this PR fixes:
Fixes #2632
Special notes for your reviewer:
Does this PR introduce a user-facing change?: