refactor: Use FetchContent for integrating three bundled libs #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.38.0 |
|
LGTM label has been added. Git tree hash: 425fd2f9b0bed58b08634efa5789766de2449da4
|
federico-sysdig
force-pushed
the
refactor-use-fetchcontent-for-njson-bundled-lib
branch
from
800e72c to
c9bd179
Compare
federico-sysdig
commented
Feb 24, 2024
Comment on lines
-19
to
-20
| #define CPPHTTPLIB_OPENSSL_SUPPORT | ||
| #define CPPHTTPLIB_ZLIB_SUPPORT |
There was a problem hiding this comment.
These two defines were resulting in a warning that the definition was already present.
federico-sysdig
force-pushed
the
refactor-use-fetchcontent-for-njson-bundled-lib
branch
from
c9bd179 to
3867147
Compare
federico-sysdig
changed the title
|
Ehy @federico-sysdig can you rebase? It should fix CI issues! |
Signed-off-by: Federico Aponte <[email protected]>
Signed-off-by: Federico Aponte <[email protected]>
federico-sysdig
force-pushed
the
refactor-use-fetchcontent-for-njson-bundled-lib
branch
from
3867147 to
51bfa9b
Compare
@FedeDP Sure. Done! |
Signed-off-by: Federico Aponte <[email protected]>
federico-sysdig
force-pushed
the
refactor-use-fetchcontent-for-njson-bundled-lib
branch
from
51bfa9b to
9498ee8
Compare
|
LGTM label has been added. Git tree hash: 49b7a5a713ef9b7607c714d433739c384e82f1fc
|
jasondellaluce
approved these changes
Mar 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Libraries
nlohmann-json,yaml-cpp, andcpp-httplibin their "bundled" configuration are now integrated through the CMake constructFetchContentrather thanExternalProject_Add. This has the benefit of being treated in a way similar to integrating the library withfind_package, thus making the bundled/non-bundled approach similar in the rest of the code.One important beneficial consequence is the simplification in client code: new targets can reference
falco_enginewithout having to specify these libs in their include path or explicitly link against it, because the targetfalco_enginebrings all the needed properties on board through the usage of aliases such ashttplib::httplibornlohmann_json::nlohmann_json.The libraries have also been upgraded as newer versions provide the target aliases and allow integration with
FetchContentwithout building the library's test targets, which obviously Falco doesn't need.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: