Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): enforce bundled deps OFF in build-dev CI #3118

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Feb 27, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP FedeDP changed the title wip: fix build-dev CI fix: build-dev CI Feb 27, 2024
@FedeDP FedeDP changed the title fix: build-dev CI fix(ci): build-dev CI Feb 27, 2024
@FedeDP FedeDP changed the title fix(ci): build-dev CI fix(ci): enforce bundled deps OFF in build-dev CI Feb 27, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As privately discussed with @FedeDP this is workaround is needed otherwise the CI will fail (with all bundled deps, it would take more than 1 hour, then fail for no space left on the disk).

@poiana
Copy link
Contributor

poiana commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f681890 into master Feb 27, 2024
27 checks passed
@poiana poiana deleted the fix/dev_ci branch February 27, 2024 10:07
@LucaGuerra
Copy link
Contributor

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants