cleanup(metrics): add original rule name as label #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melissa Kilby <[email protected]>
|
/milestone 0.38.0 |
incertum
commented
May 18, 2024
| @@ -182,6 +182,7 @@ std::string falco_metrics::to_text(const falco::app::state& state) | |||
| rules_by_id[i]->load()); | |||
| prometheus_metrics_converter.convert_metric_to_unit_convention(metric); | |||
| const std::map<std::string, std::string>& const_labels = { | |||
| {"rule", rule->name}, | |||
There was a problem hiding this comment.
Useful to preserve the original un-sanitized rule name for prometheus.
Signed-off-by: Melissa Kilby <[email protected]>
incertum
commented
May 19, 2024
| @@ -340,7 +340,7 @@ void stats_writer::collector::get_metrics_output_fields_wrapper( | |||
| { | |||
| fs::path fs_path = item.first; | |||
| std::string metric_name_file_sha256 = fs_path.filename().stem(); | |||
| metric_name_file_sha256 = "falco.sha256_rule_file." + falco::utils::sanitize_metric_name(metric_name_file_sha256); | |||
| metric_name_file_sha256 = "falco.sha256_rules_file." + falco::utils::sanitize_metric_name(metric_name_file_sha256); | |||
There was a problem hiding this comment.
We changed it to plural form elsewhere let's be consistent.
|
LGTM label has been added. Git tree hash: 4d002dfe4135a418a1de9b008a1a88ed12a73e2c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
cleanup(metrics): add original rule name as label
falcosecurity/charts#672 (comment) @leogr
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: