-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cmake): bump libs and driver to latest master #3283
Conversation
/milestone 0.39.0 |
LGTM label has been added. Git tree hash: 61dc250820589c04df0699b569d851a423f0ba96
|
@jasondellaluce seems like this isn't building because of a missing metrics method, do you have a patch for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM label has been added. Git tree hash: fed86b5e1e4ed4295b6399ff14a8b9569cc84e49
|
8e60b21
to
d1e7a05
Compare
Updated once again to bring in the changes from falcosecurity/libs#1960 |
We need to fix the windows CI that is complaining about zlib; most probably caused by this change: falcosecurity/libs#1940 or falcosecurity/libs#1899 :/ |
Incorporated the fix by @geraldcombs in the latest commit. |
Failing test:
and we also have 4 tests that are receiving heapbuffer overflow errors on x86:
|
I honestly have no idea, #3265 was failing to compile too, I checked. I must have messed up a rebase or something before merging falcosecurity/libs#1920, the |
@Molter73 after falcosecurity/libs#1971 it built just fine locally for me 🤔 |
Yeah, I messed up and left in a method that I should've removed and now it's duplicated, I'll open a PR and clean it up. I don't know if we want to rush this in though, since it's a minor cleanup, let me know what you guys think. |
No problem @Molter73, take your time! I think it would be great to clean that up for libs 0.18.0 (by the end of august), but no hurry. |
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
04f81da
to
94f94c7
Compare
Opened an issue for the test failure: falcosecurity/libs#2018 |
Also, fixes some newly introduced API breaks. Signed-off-by: Federico Di Pierro <[email protected]>
Latest commit should fix CI; moreover it accounts for API breaks from: |
Tests passed!!! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 6249f4fc5c369ef6bef06b92269e1d3dc05a571f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We did it! 🚀 😅 |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area tests
What this PR does / why we need it:
Just updating libs and fix tests to catch warnings with new output messages.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: