new(falco): add falco_libs.snaplen option, deprecate -S / --snaplen #3362
Conversation
|
/milestone 0.40.0 |
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
2 times, most recently
from
3ed01ec to
dcd1d05
Compare
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
from
dcd1d05 to
311626e
Compare
| // | ||
| if(s.config->m_falco_libs_snaplen != 0) { | ||
| inspector->set_snaplen(s.config->m_falco_libs_snaplen); | ||
| } | ||
| if(s.options.snaplen != 0) { | ||
| inspector->set_snaplen(s.options.snaplen); |
There was a problem hiding this comment.
Do we want to add the `attention this is deprectated and will be removed in..." log here? Like this one: https://github.com/falcosecurity/falco/pull/3329/files#diff-e1e4257c43745e29751e72ffa753fd44ec931b07b1bec5035f4d1b04d061848cR100
There was a problem hiding this comment.
Makes sense, will change these PRs
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
from
311626e to
19f8795
Compare
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
from
19f8795 to
7c0a062
Compare
|
@FedeDP done! |
|
LGTM label has been added. Git tree hash: f0a8c91d0a21ef5deeff46f7c1b4eee5bba3e327
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As per title. This may be the last CLI option that we couldn't replicate in the falco config file.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: