Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: add exception for write below etc #613

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented May 18, 2019

Add exception for write below etc:

etcd-manager will consistently updates dns: /etc/hosts file. This happens when k8s cluster created by kops

add new rule: create symlinks over sensitive files and directories

@Kaizhe Kaizhe requested review from fntlnz and mstemm May 18, 2019 00:46
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good, but I wanted to make sure that you only want to cover symlinks of the whole directory and not paths below it, right?

@Kaizhe
Copy link
Contributor Author

Kaizhe commented May 29, 2019

The approach looks good, but I wanted to make sure that you only want to cover symlinks of the whole directory and not paths below it, right?

Yes @mstemm, for now the target would either be a list of sensitive files or directories (directory name only, not sub directories or files under it)

@fntlnz fntlnz merged commit 7a25405 into dev May 29, 2019
@fntlnz fntlnz deleted the rule-updates-2019-05.v2 branch May 29, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants