Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: gRPC output #789

Merged
merged 6 commits into from
Sep 25, 2019
Merged

Proposal: gRPC output #789

merged 6 commits into from
Sep 25, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Aug 26, 2019 •
edited
Loading

What type of PR is this?

/kind documentation
/kind feature

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

This PR is a proposal drafted by me and @fntlnz.

It aims to design the future implementation of the gRPC output client for Falco events.

Which issue(s) this PR fixes:

Refs #528
Refs #785

Special notes for your reviewer:

Rendered version

Does this PR introduce a user-facing change?:

NONE

@leodido @fntlnz
docs(proposals): gRPC outputs goals/non-goals
507369f 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@poiana poiana requested review from Kaizhe and krisnova August 26, 2019 16:46
@leodido leodido force-pushed the feat/proposal-grpc-output branch 2 times, most recently from a3223e8 to 9252f2e Compare August 26, 2019 16:56
leodido and others added 3 commits August 26, 2019 18:57
@leodido @fntlnz
docs(proposals): proto3 definitions for grpc output proposal
801ba67 
Co-Authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
docs(proposals): design details for the gRPC output
8762782 
Co-Authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido @fntlnz
docs(proposals): grpc output design details
3a46abb 
Co-Authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido force-pushed the feat/proposal-grpc-output branch from 9252f2e to 3a46abb Compare August 26, 2019 16:57
Kaizhe
Kaizhe reviewed Aug 26, 2019
View reviewed changes
proposals/20190826-grpc-outputs.md Outdated Show resolved Hide resolved
proposals/20190826-grpc-outputs.md Outdated Show resolved Hide resolved
proposals/20190826-grpc-outputs.md Outdated Show resolved Hide resolved
@krisnova krisnova mentioned this pull request Aug 27, 2019
Closed
@leodido
Copy link
Member Author

leodido commented Aug 28, 2019

/kind design

@krisnova
Copy link
Contributor

Working agreement on the Repo planning call:

We are going to implement Falco as a gRPC server using the server streaming capability in gRPC.

Concern about having exposed ports and DoS from exposing them.

@fntlnz suggests having the gRPC as an opt-in feature.

This was referenced Aug 30, 2019
Closed
Closed
@krisnova
Copy link
Contributor

krisnova commented Sep 6, 2019

Let's get this merged please :)

We want our original design documented in our HEAD branch. We need to start comparing what we "propose" VS what we "do". It's an important exercise. We do this in upstream Kubernetes, and I think we learn a lot about our process from this.

@krisnova
Copy link
Contributor

krisnova commented Sep 6, 2019

/lgtm

@poiana poiana added the lgtm label Sep 6, 2019
@poiana
Copy link
Contributor

poiana commented Sep 6, 2019

LGTM label has been added.

Git tree hash: 76296dc95214170c929c14d0e15729d6dfdbc24a

@poiana poiana added the approved label Sep 6, 2019
@leodido leodido mentioned this pull request Sep 6, 2019
Merged
31 tasks
@fntlnz fntlnz mentioned this pull request Sep 11, 2019
Closed
@leodido @fntlnz
update(proposals): address review comments and suggestions
e43baeb 
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido force-pushed the feat/proposal-grpc-output branch from 26eac75 to 1df0e1d Compare September 25, 2019 09:26
@toc-me @fntlnz @leodido
update(proposals): ToC for proposals/20190826-grpc-outputs.md
7bc0213 
Co-authored-by: Lorenzo Fontana <[email protected]>
Co-authored-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido leodido force-pushed the feat/proposal-grpc-output branch from 1df0e1d to 7bc0213 Compare September 25, 2019 09:26
@poiana poiana added the lgtm label Sep 25, 2019
@poiana
Copy link
Contributor

poiana commented Sep 25, 2019

LGTM label has been added.

Git tree hash: 8ff3fe23f5090491608712d5c4642991db3a764a

@poiana
Copy link
Contributor

poiana commented Sep 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido merged commit 6f18b0d into dev Sep 25, 2019
@poiana poiana deleted the feat/proposal-grpc-output branch September 25, 2019 11:37
@fntlnz
Copy link
Contributor

fntlnz commented Oct 7, 2019

/area proposals

@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisnova krisnova krisnova left review comments

@rajibmitra rajibmitra rajibmitra left review comments

@Kaizhe Kaizhe Kaizhe left review comments

@fntlnz fntlnz fntlnz approved these changes

Assignees

@leodido leodido

@fntlnz fntlnz

@krisnova krisnova

Labels
approved area/proposals dco-signoff: yes kind/design kind/documentation kind/feature lgtm release-note-none size/L
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@leodido @krisnova @poiana @fntlnz @Kaizhe @rajibmitra