Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Loongarch64 support #381

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yzewei
Copy link

@yzewei yzewei commented Jan 15, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

Add Loongarch64 support
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link
Contributor

poiana commented Jan 15, 2024

Welcome @yzewei! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@cpanato
Copy link
Member

cpanato commented Jan 15, 2024

is there any issue with this feature?

cc @leogr

@cpanato
Copy link
Member

cpanato commented Jan 15, 2024

/ok-to-test

@leogr
Copy link
Member

leogr commented Jan 15, 2024

is there any issue with this feature?

cc @leogr

I don't believe there's any particular issue. We may just need to understand if testing is easy (I guess so).

@falcosecurity/falcoctl-maintainers @alacuku @loresuso wdyt?

@FedeDP
Copy link
Contributor

FedeDP commented Jan 15, 2024

I think there is no need to support loongarch64 on falcoctl, unless someone wants to run the Falco stack on it.
I'd love to go on with this (and falcosecurity/syscalls-bumper#28) once we have PRs opened to support loongarch64 for our drivers, since without them, it makes no sense to support this (unless the user wants to run Falco with plugins only).
Anyway, i want to highlight that we won't support loongarch64 architecture officially (ie: no prebuilt artifacts).

@alacuku
Copy link
Member

alacuku commented Jan 15, 2024

Hi @yzewei, thank you for the PR.

We need to release also the docker image of falcoctl for Loongarch64. Building the binary is not enough if we want full support for the Loongarch64 architecture.

You updated the integration tests for the artifacts built for Loongarch64 architecture. Currently, our plugins (artifacts) support only linux/amd64 and linux/arm64. Do you have any plugin built for Loongarch64?

Another thing is that as far as I know the Falco does not support Loongarch64, having falcoctl that supports it does not add any value. It could trick people into thinking that Falco is ready for linux/loongarch64 platform.

Let's see what the other maintainers think about it.

@yzewei
Copy link
Author

yzewei commented Jan 15, 2024

Hi @yzewei, thank you for the PR.

We need to release also the docker image of falcoctl for Loongarch64. Building the binary is not enough if we want full support for the Loongarch64 architecture.

You updated the integration tests for the artifacts built for Loongarch64 architecture. Currently, our plugins (artifacts) support only linux/amd64 and linux/arm64. Do you have any plugin built for Loongarch64?

Another thing is that as far as I know the Falco does not support Loongarch64, having falcoctl that supports it does not add any value. It could trick people into thinking that Falco is ready for linux/loongarch64 platform.

Let's see what the other maintainers think about it.

I am trying to provide falco loongarch64 support
If you need to build a docker image of the linux/loong64 platform, a separate Dockerfile file may be required.

@yzewei
Copy link
Author

yzewei commented Jan 15, 2024

The original intention of this PR was due to the needs of the Falco project. Position: cmake/modules/falcoctl.cmake

@leogr
Copy link
Member

leogr commented Jan 16, 2024

The original intention of this PR was due to the needs of the Falco project. Position: cmake/modules/falcoctl.cmake

@yzewei
So, are you working on making Falco build on Loongarch64?

@yzewei
Copy link
Author

yzewei commented Jan 16, 2024

The original intention of this PR was due to the needs of the Falco project. Position: cmake/modules/falcoctl.cmake

@yzewei So, are you working on making Falco build on Loongarch64?

Of course, this is what I am doing

@cpanato
Copy link
Member

cpanato commented Jan 17, 2024

@leogr, I am more interested to know if we have any data that show the usage of Falco on this architecture; also would like to learn what are the changes and how easy it will be to run tests.

@leogr
Copy link
Member

leogr commented Jan 17, 2024

@leogr, I am more interested to know if we have any data that show the usage of Falco on this architecture; also would like to learn what are the changes and how easy it will be to run tests.

We don't have any data since Loongarch64 is not supported yet.

@yzewei
Copy link
Author

yzewei commented Jan 18, 2024

@leogr, I am more interested to know if we have any data that show the usage of Falco on this architecture; also would like to learn what are the changes and how easy it will be to run tests.

Adaptation and support for the loongarch64 kernel module

@leogr
Copy link
Member

leogr commented Mar 26, 2024

Let this on
/hold
until we get Loongarch64 support in libs and (possibly) in Falco

@poiana
Copy link
Contributor

poiana commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yzewei
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yzewei
Copy link
Author

yzewei commented Jul 2, 2024

Let this on /hold until we get Loongarch64 support in libs and (possibly) in Falco

@leogr Loongarch was added to libs support two months ago, even though it is only driver-driven.

@leogr
Copy link
Member

leogr commented Jul 3, 2024

I guess we need a Falco build first. But I'm open to discussing.

@falcosecurity/core-maintainers WDYT?

@poiana
Copy link
Contributor

poiana commented Oct 1, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@maxgio92
Copy link
Member

/remove-lifecycle stale

I'd track the changes into an umbrella issue on https://github.com/falcosecurity/falco repository, for the support among the driver, libs, Falco and plugins. WDYT @falcosecurity/core-maintainers?

@poiana
Copy link
Contributor

poiana commented Jan 13, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants