-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Loongarch64 support #381
base: main
Are you sure you want to change the base?
Conversation
Welcome @yzewei! It looks like this is your first PR to falcosecurity/falcoctl 🎉 |
is there any issue with this feature? cc @leogr |
/ok-to-test |
I think there is no need to support loongarch64 on falcoctl, unless someone wants to run the Falco stack on it. |
Hi @yzewei, thank you for the PR. We need to release also the docker image of falcoctl for You updated the integration tests for the artifacts built for Another thing is that as far as I know the Falco does not support Let's see what the other maintainers think about it. |
I am trying to provide falco loongarch64 support |
The original intention of this PR was due to the needs of the Falco project. Position: cmake/modules/falcoctl.cmake |
@yzewei |
Of course, this is what I am doing |
@leogr, I am more interested to know if we have any data that show the usage of Falco on this architecture; also would like to learn what are the changes and how easy it will be to run tests. |
Signed-off-by: yzewei <[email protected]>
We don't have any data since Loongarch64 is not supported yet. |
Adaptation and support for the loongarch64 kernel module |
Let this on |
Signed-off-by: yzewei <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yzewei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@leogr Loongarch was added to libs support two months ago, even though it is only driver-driven. |
I guess we need a Falco build first. But I'm open to discussing. @falcosecurity/core-maintainers WDYT? |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale I'd track the changes into an umbrella issue on https://github.com/falcosecurity/falco repository, for the support among the driver, libs, Falco and plugins. WDYT @falcosecurity/core-maintainers? |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
Add Loongarch64 support
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: