Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use testify to check the test results #108

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 18, 2020

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area tests

What this PR does / why we need it:

Use testify to assert the test results to make more clean and avoid writing more code

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Nov 18, 2020

@cpanato: The label(s) area/tests cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area tests

What this PR does / why we need it:

Use testify to assert the test results to make more clean and avoid writing more code

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Nov 18, 2020

testfy catchs a broken test :)

Signed-off-by: Carlos Panato <[email protected]>
@poiana
Copy link

poiana commented Nov 18, 2020

LGTM label has been added.

Git tree hash: a7252c423abc8b33830410c7112a20d013157c4c

@poiana
Copy link

poiana commented Nov 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d529805 into falcosecurity:master Nov 18, 2020
@cpanato cpanato deleted the use-testify branch November 18, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants