Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom headers not added to loki output http/s requests #1107

Merged

Conversation

lsroe
Copy link
Contributor

@lsroe lsroe commented Jan 29, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
Adds LOKI_CUSTOMHEADERS to http/s requests as expected

Which issue(s) this PR fixes:

Fixes #1108

Special notes for your reviewer:

@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/feature New feature or request labels Jan 29, 2025
@poiana poiana requested review from fjogeleit and Issif January 29, 2025 10:44
@poiana
Copy link

poiana commented Jan 29, 2025

Welcome @lsroe! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link

poiana commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, lsroe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 29, 2025

LGTM label has been added.

Git tree hash: 0c5d553a18bdbac704d842824b019590ba6432df

@Issif Issif added this to the 2.31 milestone Jan 29, 2025
@poiana poiana merged commit 4a634b0 into falcosecurity:master Jan 29, 2025
5 checks passed
@lsroe lsroe deleted the fix/loki-custom-headers-not-added branch January 29, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Loki output does not contain custom headers defined via env variable
3 participants