-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .dockerignore for small Docker images #126
Add .dockerignore for small Docker images #126
Conversation
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@cpanato: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart. I love it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 5de5d93ad6123d122a549d4f748f63cb5907797c
|
Signed-off-by: KeisukeYamashita [email protected]
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Optimization.
We don't need
.git/
(3.4MB
) andimg/
(1.0MB
) in the docker image. Smaller Docker images will use fewer resources and it makes the image safer.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Adding to much Docker ignore files worsen the build time and I think other files(e.g.
README.md
(32KB)) does not worth ignoring it.