Add alertmanager variable to choose the endpoint version of alertmanager api #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger api Signed-off-by: Mathilde Hermet <[email protected]>
mathildeHermet
force-pushed
the
add_choice_api_version_alertmanager
branch
from
30612e8 to
4b09f4b
Compare
Issif
approved these changes
Nov 19, 2021
|
LGTM label has been added. Git tree hash: aad54bbdb0ac40d007ac145de0e5a128771db988
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, mathildeHermet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathilde Hermet [email protected]
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
What this PR does / why we need it:
There are two versions of Alertmanager endpoint to post alerts: v1 and v2.
Previously, this endpoint was hardcoded with v1.
As a result, an upgrade of Alertmanager might leads to an impossible communication between Falcosidekick and Alertmanager.
Which issue(s) this PR fixes:
Fixes #280