Allow EndsAt field to be specified for alertmanager alerts #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Marshall <[email protected]>
poiana
added
kind/feature
|
Welcome @danieljmt! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Signed-off-by: Daniel Marshall <[email protected]>
|
/assign @leogr |
Issif
requested changes
May 23, 2022
Signed-off-by: Daniel Marshall <[email protected]>
|
Updated |
Issif
approved these changes
May 23, 2022
|
LGTM label has been added. Git tree hash: 4b114f6fa0dd6637f51b3e9ad0506d8ba0867b6a
|
|
Looks like |
fjogeleit
approved these changes
May 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danieljmt, fjogeleit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it:
Allows the EndsAt alert parameter to be configured
Which issue(s) this PR fixes:
Fixes #322
Special notes for your reviewer: N/A