Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing returned errors #573

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix missing returned errors #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion outputs/kafka.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func NewKafkaClient(config *types.Configuration, stats *types.Statistics, promSt
case "round_robin":
kafkaWriter.Balancer = &kafka.RoundRobin{}
default:
log.Printf("[ERROR] : Kafka - unsupported balancer %q\n", config.Kafka.Balancer)
return nil, fmt.Errorf("unsupported balancer %q", config.Kafka.Balancer)
}

Expand All @@ -97,6 +98,7 @@ func NewKafkaClient(config *types.Configuration, stats *types.Statistics, promSt
case "NONE":
// leave as default, none
default:
log.Printf("[ERROR] : Kafka - unsupported compression %q\n", config.Kafka.Compression)
return nil, fmt.Errorf("unsupported compression %q", config.Kafka.Compression)
}

Expand All @@ -108,7 +110,8 @@ func NewKafkaClient(config *types.Configuration, stats *types.Statistics, promSt
case "NONE":
kafkaWriter.RequiredAcks = kafka.RequireNone
default:
return nil, fmt.Errorf("unsupported required ACKs %q", config.Kafka.Compression)
log.Printf("[ERROR] : Kafka - unsupported required ACKs %q\n", config.Kafka.RequiredACKs)
return nil, fmt.Errorf("unsupported required ACKs %q", config.Kafka.RequiredACKs)
}

client := &Client{
Expand Down