Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate output fiels with a length > 512 chars #871

Merged
merged 1 commit into from
May 8, 2024
Merged

truncate output fiels with a length > 512 chars #871

merged 1 commit into from
May 8, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented May 3, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Multiple outputs fail when the length of the payload is > 4906 characters. This PR introduces a truncate of the outputs fields to max 512 characters when the global length of the payload is > 4096.

Which issue(s) this PR fixes:

#842

Fixes #

Special notes for your reviewer:

…not accepted by a lot of outputs

Signed-off-by: Thomas Labarussias <[email protected]>
@Issif Issif added this to the 2.29.0 milestone May 3, 2024
@leogr
Copy link
Member

leogr commented May 8, 2024

/kind bug

@poiana poiana added kind/bug Something isn't working and removed needs-kind labels May 8, 2024
@poiana poiana added the lgtm label May 8, 2024
@poiana
Copy link

poiana commented May 8, 2024

LGTM label has been added.

Git tree hash: 7c805664ab03c767ca20f7debca247981888afec

@poiana
Copy link

poiana commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4d88ddf into master May 8, 2024
5 checks passed
@poiana poiana deleted the fix/842 branch May 8, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants