Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting unit tests for token_bucket from falco to libsinsp #137

Closed
jasondellaluce opened this issue Nov 18, 2021 · 0 comments · Fixed by #154
Closed

porting unit tests for token_bucket from falco to libsinsp #137

jasondellaluce opened this issue Nov 18, 2021 · 0 comments · Fixed by #154
Labels
kind/feature New feature or request

Comments

@jasondellaluce
Copy link
Contributor

Motivation

As token_bucket has recently been removed from the falco repository and is now only part of libsinsp, the unit tests need to be moved into libsinsp too. See 👇🏼
falcosecurity/falco#1753
ca51f17

For context, this is the PR I opened on falco to remove the leftover unit test file 👇🏼
falcosecurity/falco#1798

Feature

It would be meaningful to port the unit tests to libsinsp and adapt them to use gtest.

Alternatives

Writing the unit tests from scratch, or just leave things as they are.

@jasondellaluce jasondellaluce added the kind/feature New feature or request label Nov 18, 2021
leogr pushed a commit to leogr/libs that referenced this issue Jan 5, 2023

Verified

This commit was signed with the committer’s verified signature.
…CRI (falcosecurity#137)

This change increases the number of retries to retrieve the container
information from CRI API from 3 to 5, as several failures were observed
with the maximum number of attempts set to 3.

Signed-off-by: Iacopo Rozzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant