new(libsinsp): add iglob operator #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
FedeDP
reviewed
Dec 5, 2023
userspace/libsinsp/utils.h
Outdated
| @@ -113,7 +113,7 @@ class sinsp_utils | |||
|
|
|||
| static uint64_t get_current_time_ns(); | |||
|
|
|||
| static bool glob_match(const char *pattern, const char *string); | |||
| static bool glob_match(const char *pattern, const char *string, const bool& case_insensitive); | |||
There was a problem hiding this comment.
A default value of "false" here great le reduces the diff.
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
new-iglob
branch
from
c31a5b0 to
394e251
Compare
therealbobo
changed the title
|
LGTM label has been added. Git tree hash: df12305ccda7fcc42f1e64f62ad00cb703bc62b4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@therealbobo I think this is an user facing change! Mind to add a release note? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This adds the
igloboperator for glob case-incentive matching.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: