Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: build: upgrade grpc deps #29

Closed
wants to merge 5 commits into from
Closed

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 1, 2021

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

leogr added 2 commits April 1, 2021 09:54
Note that s390x has not been upgraded and might be broken.

Signed-off-by: Leonardo Grasso <[email protected]>
@poiana
Copy link
Contributor

poiana commented Apr 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from leogr after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from ldegio and leodido April 1, 2021 09:58
@poiana poiana added the size/M label Apr 1, 2021
@leogr leogr force-pushed the build/upgrade-grpc-deps branch from c988cdd to 53ef2fb Compare April 1, 2021 10:59
@leogr leogr force-pushed the build/upgrade-grpc-deps branch from 53ef2fb to f602e7e Compare April 1, 2021 17:38
@leogr
Copy link
Member Author

leogr commented Apr 2, 2021

I have changed my mind about this approach. Closing atm

@leogr leogr closed this Apr 2, 2021
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr leogr reopened this Apr 2, 2021
@leogr leogr closed this Apr 2, 2021
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr leogr reopened this Apr 6, 2021
@leogr leogr closed this Apr 6, 2021
@poiana poiana mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants