Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the license passed in bpf_attr #37

Closed
wants to merge 1 commit into from
Closed

Keep the license passed in bpf_attr #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions userspace/libscap/scap_bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ static int bpf_load_program(const struct bpf_insn *insns,
attr.prog_type = type;
attr.insn_cnt = (uint32_t) insns_cnt;
attr.insns = (unsigned long) insns;
attr.license = (unsigned long) "GPL";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as a workaround. The root issue should be in our loader (that is not parsing 'license' section).

Could we add a comment so we won't forget to fix the loader in the future?

attr.log_buf = (unsigned long) NULL;
attr.log_size = 0;
attr.log_level = 0;
Expand Down