refactor(userspace/libsinsp): remove unused check_id from events #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
changed the title
|
/retest |
mstemm
approved these changes
Jun 7, 2022
|
LGTM label has been added. Git tree hash: 6ce3f7728a8d69dbb96707a96b18de2f9a073c0b
|
jasondellaluce
changed the title
Andreagit97
approved these changes
Jun 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dellaluce [email protected]
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
What this PR does / why we need it:
Since merging falcosecurity/falco#2017, the
set_check_idandget_check_idmethods are not required in events anymore. The check id was an historically instrumental for Falco to figure out which rule and filtercheck matched a given event. This is now not used anymore because the rule-event matching is a responsiblity of the Falco Engine exclusively. Removing this also saves the cost of many memory writes at each filtercheck evaluation.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: