-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(rules): initial tagging of stable rules round4 #110
Conversation
Includes: * enhanced desc * more complete output fields * cleanup of tags if applicable * add new maturity_stable tag Signed-off-by: Melissa Kilby <[email protected]>
Java applications very often have a custom process name, therefore proc.name or proc.pname are not well suited for rules conditions to determine java applications, use 'proc.exe endswith java' instead, same for proc.pexe etc. Signed-off-by: Melissa Kilby <[email protected]>
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Patch changes:
|
@@ -1522,7 +1522,7 @@ | |||
condition: (proc.aname[2]=rabbitmqctl and proc.cmdline startswith "sh -c ") | |||
|
|||
- macro: run_by_appdynamics | |||
condition: (proc.pname=java and proc.pcmdline startswith "java -jar -Dappdynamics") | |||
condition: (proc.pexe endswith java and proc.pcmdline contains " -jar -Dappdynamics") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks odd at first but at least we're guarded from processes that change their name and it doesn't introduce a false positive (I mean, unless we have something called stuff-java
and has the same CLI options as these tools, which is very unlikely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: 7a5f79dcf64c1732770030e1f63973d9a0dcdeb5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Fourth round of initially tagging rules w/ maturity_stable.
@LucaGuerra @loresuso @jasondellaluce
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: