Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(build/registry): make sure new artifacts requirements contain … #185

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Nov 2, 2023

…the new engine_version_semver key.

All the rules are already modified to contain a semver string

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
Find more details in falcosecurity/falco#2899

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link

github-actions bot commented Nov 2, 2023

Rules files suggestions

falco_rules.yaml

Comparing 75460a5895d1b2e75c5e7ed19a2099beb16ba4d8 with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

falco-sandbox_rules.yaml

Comparing 75460a5895d1b2e75c5e7ed19a2099beb16ba4d8 with latest tag falco-sandbox-rules-2.0.0

No changes detected

falco-incubating_rules.yaml

Comparing 75460a5895d1b2e75c5e7ed19a2099beb16ba4d8 with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Adding ssh keys to authorized_keys has been added
  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Macro glibc_tunables_env has been added

…the new `engine_version_semver` key.

All the rules are already modified to contain a semver string

Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso loresuso force-pushed the engine-version-semver branch from 0466843 to 533022a Compare November 3, 2023 13:53
Copy link

github-actions bot commented Nov 3, 2023

Rules files suggestions

falco_rules.yaml

Comparing 688bcb20c06b920ee390264d47e9fc373209a84b with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

falco-sandbox_rules.yaml

Comparing 688bcb20c06b920ee390264d47e9fc373209a84b with latest tag falco-sandbox-rules-2.0.0

No changes detected

falco-incubating_rules.yaml

Comparing 688bcb20c06b920ee390264d47e9fc373209a84b with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Adding ssh keys to authorized_keys has been added
  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Macro glibc_tunables_env has been added

Copy link

github-actions bot commented Nov 3, 2023

Rules files suggestions

falco_rules.yaml

Comparing aef3930c7839d50ac9e053286d63985a0ce7a368 with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

falco-sandbox_rules.yaml

Comparing aef3930c7839d50ac9e053286d63985a0ce7a368 with latest tag falco-sandbox-rules-2.0.0

No changes detected

falco-incubating_rules.yaml

Comparing aef3930c7839d50ac9e053286d63985a0ce7a368 with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Adding ssh keys to authorized_keys has been added
  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Macro glibc_tunables_env has been added

@loresuso loresuso force-pushed the engine-version-semver branch from 5990906 to 533022a Compare November 3, 2023 14:33
Copy link

github-actions bot commented Nov 3, 2023

Rules files suggestions

falco_rules.yaml

Comparing 8659da816e909df0eafec69967ff60f7d508d0f7 with latest tag falco-rules-2.0.0

Minor changes:

  • Macro containerd_activities has been added

falco-sandbox_rules.yaml

Comparing 8659da816e909df0eafec69967ff60f7d508d0f7 with latest tag falco-sandbox-rules-2.0.0

No changes detected

falco-incubating_rules.yaml

Comparing 8659da816e909df0eafec69967ff60f7d508d0f7 with latest tag falco-incubating-rules-2.0.0

Minor changes:

  • Rule Potential Local Privilege Escalation via Environment Variables Misuse has been added
  • Rule Adding ssh keys to authorized_keys has been added
  • Macro glibc_tunables_env has been added

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 7, 2023

LGTM label has been added.

Git tree hash: c2ce80e8858cb99acd035d90382c265b60cf8d01

@poiana poiana added the approved label Nov 7, 2023
@poiana poiana merged commit 8f0520f into falcosecurity:main Nov 7, 2023
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants