Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(falco_rules): disable three rules by default #34

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

This sets three rules as disabled by default, each for a different reason:

  • Contact EC2 Instance Metadata Service From Container: without custom overrides, the rule contains the unrolled condition container and not container, which means that the rule never triggers at default and just wastes evaluation time.
  • Outbound Connection to C2 Servers: without custom overrides, the condition will require one of fd.sip and fd.sip.name to be contained in empty lists, which is impossible, meaning that the rule never triggers at default and just wastes evaluation time.
  • Java Process Class File Download: This matches the recvfrom syscall, which is IO-related and performance-heavy. The recent Falco developments will automatically exclude those syscalls if the -A option is not used, which means that this rule will never trigger by default in the next Falco release.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana
Copy link

poiana commented Feb 24, 2023

@jasondellaluce: The label(s) kind/cleanup, area/rules cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

This sets three rules as disabled by default, each for a different reason:

  • Contact EC2 Instance Metadata Service From Container: without custom overrides, the rule contains the unrolled condition container and not container, which means that the rule never triggers at default and just wastes evaluation time.
  • Outbound Connection to C2 Servers: without custom overrides, the condition will require one of fd.sip and fd.sip.name to be contained in empty lists, which is impossible, meaning that the rule never triggers at default and just wastes evaluation time.
  • Java Process Class File Download: This matches the recvfrom syscall, which is IO-related and performance-heavy. The recent Falco developments will automatically exclude those syscalls if the -A option is not used, which means that this rule will never trigger by default in the next Falco release.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@loresuso loresuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!
/approve

@poiana
Copy link

poiana commented Mar 15, 2023

LGTM label has been added.

Git tree hash: a337407533c1c469e8234845be1ede249f808c5a

Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree with this. users can enable those rules is specifically interested in the use case adding values to lists and changing macros.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, FedeDP, jasondellaluce, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 83b4248 into main Mar 15, 2023
@poiana poiana deleted the update/disable-default-some-rules branch March 15, 2023 11:55
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants