Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules)!: require explicit accept4 reference, overlapping syscall names deprecated #44

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

incertum
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

A major refactor of Falco now exposes each syscall Falco's libs supports to the end user :)

At the same time we deprecate overlapping syscall names, see falcosecurity/falco#2443 (comment)

Official support starts with Falco 0.35.0

Which issue(s) this PR fixes:

falcosecurity/falco#2443

Fixes #

Special notes for your reviewer:

CC @leogr @jasondellaluce @FedeDP @Andreagit97

…names deprecated

A major refactor of Falco now exposes each syscall Falco's libs
supports to the end user :)

At the same time we deprecate overlapping syscall names,
see falcosecurity/falco#2443 (comment)

Official support starts with Falco 0.35.0

Co-authored-by: Jason Dellaluce <[email protected]>
Co-authored-by: Andrea Terzolo <[email protected]>
Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: incertum <[email protected]>
Copy link
Member

@loresuso loresuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!
/approve

@poiana
Copy link

poiana commented Apr 3, 2023

LGTM label has been added.

Git tree hash: 36b98dcb95752a9f5253b57609b91c29c47d47f5

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thank you!

@poiana
Copy link

poiana commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 3, 2023
@Andreagit97 Andreagit97 added this to the falco-rules-0.2 milestone Apr 3, 2023
@poiana poiana merged commit 694adf5 into falcosecurity:main Apr 3, 2023
@Andreagit97 Andreagit97 removed this from the falco-rules-0.2 milestone Apr 3, 2023
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants