-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AKS rules #53
Adding AKS rules #53
Conversation
Signed-off-by: Michael Dreher <[email protected]>
Welcome @migg24! It looks like this is your first PR to falcosecurity/rules 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, seeing changes to reduce the noise is always great!
I dropped just a comment on a couple of images if you could provide further info would be appreciated.
Signed-off-by: Michael Dreher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @migg24,
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, LucaGuerra, migg24 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 10a9ac55b95dce2d6f4d4623acad4a9f27adcbb1
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Adding rules for running Falco on Azure Kubernetes Services (AKS) with less false positives.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I hope this is fine and I did not miss any rules for contributing.