Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AKS rules #53

Merged
merged 2 commits into from
May 17, 2023
Merged

Adding AKS rules #53

merged 2 commits into from
May 17, 2023

Conversation

migg24
Copy link
Contributor

@migg24 migg24 commented May 2, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:
Adding rules for running Falco on Azure Kubernetes Services (AKS) with less false positives.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I hope this is fine and I did not miss any rules for contributing.

@poiana
Copy link

poiana commented May 2, 2023

Welcome @migg24! It looks like this is your first PR to falcosecurity/rules 🎉

@poiana poiana requested review from Kaizhe and loresuso May 2, 2023 14:52
@poiana poiana added the size/S label May 2, 2023
Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, seeing changes to reduce the noise is always great!
I dropped just a comment on a couple of images if you could provide further info would be appreciated.

rules/falco_rules.yaml Outdated Show resolved Hide resolved
Signed-off-by: Michael Dreher <[email protected]>
@migg24 migg24 requested a review from darryk10 May 4, 2023 07:15
Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @migg24,
LGTM

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@LucaGuerra
Copy link
Contributor

/approve

@LucaGuerra
Copy link
Contributor

/lgtm

@poiana
Copy link

poiana commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, LucaGuerra, migg24

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented May 17, 2023

LGTM label has been added.

Git tree hash: 10a9ac55b95dce2d6f4d4623acad4a9f27adcbb1

@poiana poiana merged commit 6da15ae into falcosecurity:main May 17, 2023
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants