Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rules/falco_rules.yaml): fix comment #74

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Just here to give a final test round to the CI.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

rules/falco_rules.yaml

Comparing e6d87f3bdb17e571dfad9102de055a8f2c9eb323 with latest tag falco-rules-0.1.0

Major changes:

  • List white_listed_modules has been removed
  • Rule Contact EC2 Instance Metadata Service From Container has been disabled at default
  • Rule Outbound Connection to C2 Servers has been disabled at default
  • Rule Java Process Class File Download has been disabled at default

Minor changes:

  • Required engine version was incremented from 13 to 17
  • Rule PTRACE anti-debug attempt has been added
  • Rule Drop and execute new binary in container has been added
  • Macro ptrace_attach_or_injection has been added
  • Macro kernel_module_load has been added
  • Macro known_aks_mount_in_privileged_containers has been added
  • List known_drop_and_execute_containers has been added
  • List allowed_container_images_loading_kernel_module has been added
  • List authorized_server_binary has been added
  • List python_package_managers has been added

Patch changes:

  • Rule Linux Kernel Module Injection Detected changed its output fields
  • Rule PTRACE attached to process matches more events than before
  • List docker_binaries has some item added or removed
  • List rpm_binaries has some item added or removed
  • List package_mgmt_binaries has some item added or removed
  • List safe_etc_dirs has some item added or removed
  • List falco_privileged_images has some item added or removed
  • List network_tool_binaries has some item added or removed
  • List user_known_k8s_ns_kube_system_images has some item added or removed

@jasondellaluce
Copy link
Contributor Author

Automatic comments work on forks too! I'll let reviewers decide whether to merge this or not.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I love it! feel free to unhold it if you think it is ready
/hold

@poiana
Copy link

poiana commented Jun 1, 2023

LGTM label has been added.

Git tree hash: 671b86f88c832316aec56da0113cb7d5ab7b4c89

@poiana
Copy link

poiana commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasondellaluce
Copy link
Contributor Author

/unhold

@poiana poiana merged commit 04d7b9d into falcosecurity:main Jun 1, 2023
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants