improve contributors formatting #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves the formatting of contributors in the project by using a `hashset` to ensure contributors are only listed once. this is done by introducing a new `unify_contributors` function, which takes a list of contributors as a `string` and returns the same `string` with only unique contributors. this commit updates the `format_contributors_to_md` function to call `unify_contributors` and passes in the list of contributors, which is formatted with the `format_items_to_md` function. the `unify_contributors` function uses a `hashset` to store and remove duplicate contributors. the `hashset` is then iterated over and the unique values are added to a `vec` which is then joined with a new line character to form a `string` of unique contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves the formatting of contributors in the project by using a
hashsetto ensure contributors are only listed once. this is done by introducing a newunify_contributorsfunction, which takes a list of contributors as astringand returns the samestringwith only unique contributors.this commit updates the
format_contributors_to_mdfunction to callunify_contributorsand passes in the list of contributors, which is formatted with theformat_items_to_mdfunction. theunify_contributorsfunction uses ahashsetto store and remove duplicate contributors. thehashsetis then iterated over and the unique values are added to avecwhich is then joined with a new line character to form astringof unique contributors.