This repository has been archived by the owner on Dec 25, 2024. It is now read-only.
Simpler version check because we do not need to know about pre-release versions when checking for updates #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e versions when checking for updates Use `System.Version` to check for new versions instead of some complex version library for semantic versioning because 1. We do not advice updating to pre-release versions automatically (e.g. 1.0.0-beta or 1.12.1-pr0271-0047). 2. Should this change, we can use: - NuGet.Versioning (https://www.nuget.org/packages/NuGet.Versioning/) - Semver (https://www.nuget.org/packages/Semver/) - SemanticVersioning (https://www.nuget.org/packages/SemanticVersioning/) Official support was requested but has not been added yet: dotnet/runtime#19317
mburumaxwell
force-pushed
the
simple-version-check
branch
from
ee58b2a to
176ac71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
System.Versionto check for new versions instead of some complex version library for semantic versioning because