Another go at updating dependencies #192

joneshf · 2016-10-23T11:35:09Z

rjmk · 2016-10-23T11:38:08Z

README.md

@@ -25,7 +25,7 @@ structures:
 * [Bifunctor](#bifunctor)
 * [Profunctor](#profunctor)

-<img src="figures/dependencies.png" width="677" height="212" />
+<img src="figures/dependencies.png" />


Could we use the svg rather than the png here?

Could just kill the png altogether.

Sounds good to me. See my Stack Overflow answer.

@rpominov added the dimensions in #119 for a good reason. We should specify the new dimensions to avoid regressing.

davidchambers · 2016-10-23T11:42:50Z

figures/dependencies.dot

@@ -0,0 +1,35 @@
+digraph {
+  node [fontcolor=blue;shape=plaintext]


Let's s/blue/#4078c0/ to match GitHub's link colour.

davidchambers · 2016-10-23T11:44:04Z

README.md

@@ -25,7 +25,7 @@ structures:
 * [Bifunctor](#bifunctor)
 * [Profunctor](#profunctor)


Let's remove this list. It's duplicative now that the diagram is up to date. :)

I think it's best to keep this. It's nice to have a fallback in case something happens with the image, different people process information differently, and it's still plaintext so it can be searched.

Two points in favour of the ASCII version. 😜

😄

I'm fine with the output graph being ASCII. I just don't want to maintain the shape of the graph in raw ASCII.

I'm totally with you. A program like dot which generates an ASCII diagram would be neat!

I very much like your change. Thanks for taking the time to work on it.

It does support multiple output formats, including plain. plain gives you the size of the graph, a sequence of nodes with positions, and a sequence of edges with position if you want to parse the coordinates into an ascii thing. It looks like a regular language, so probably not too hard to parse.

Cool! I may investigate that one day (but certainly not today).

davidchambers · 2016-10-23T12:01:34Z

README.md

@@ -25,7 +25,7 @@ structures:
 * [Bifunctor](#bifunctor)
 * [Profunctor](#profunctor)

-<img src="figures/dependencies.png" width="677" height="212" />
+<img src="https://cdn.rawgit.com/fantasyland/fantasy-land/master/figures/dependencies.svg" />


This is inadvisable:

Use a specific tag or commit hash in the URL (not a branch). Files are cached permanently based on the URL.

The approach I used with Orthogonal was to add the SVG in one commit then reference its location by commit hash in the following commit.

Ah! Makes sense.

davidchambers · 2016-10-23T12:04:12Z

@joneshf, what command are you running to generate dependencies.svg? Could you add it to a makefile so the rest of us know how to do it?

joneshf · 2016-10-23T12:41:46Z

This file: https://github.com/fantasyland/fantasy-land/blob/4c1e3ee239c9a68e8d0a9a299b663e48d4cb6cfe/figures/dependencies.sh

davidchambers · 2016-10-23T12:47:55Z

The links in the image do not work, because GitHub wraps the image in an anchor element. Shall we remove the links? Since we're going to keep the list of section links they're not essential.

joneshf · 2016-10-23T12:55:03Z

Sure.

davidchambers · 2016-10-23T13:12:17Z

It's looking good! Ideally we'd now have two clean commits:

Commit 1:

add figures/dependencies.dot
add figures/dependencies.sh
update figures/dependencies.svg

Commit 2:

update README.md to point to RawGit SVG (include hash of Commit 1)
remove figures/dependencies.mp
remove figures/dependencies.png

I'm happy to do this if fiddling with git rebase is not the way you like to spend your Sundays. :)

⚠️ We'll then merge the pull request without using the "squash and merge" feature.

joneshf · 2016-10-23T13:27:39Z

Nah, rebase is fine.

I wonder if svg is worth it if we have to use rawgit like this. Remembering to make one commit to change the graph and one to update the sha is less than ideal. If we use png rather than svg for output, it seems like we could do it in one commit, and similar for future changes. What do you think?

davidchambers · 2016-10-23T13:30:16Z

Good point. Let's stick with a PNG. :)

davidchambers · 2016-10-23T14:19:56Z

Excellent! If you're happy with the current state of the diff, Hardy, let's squash and merge. :)

SimonRichardson · 2016-10-23T18:25:35Z

👍

* 'master' of github.com:fantasyland/fantasy-land: (29 commits) Version 2.1.0 Add Alt, Plus and Alternative specs (fantasyland#197) Use uppercase letters for Type representatives in laws (fantasyland#196) Fix id_test and argument order in laws (fantasyland#193) Version 2.0.0 Another go at updating dependencies (fantasyland#192) release: integrate xyz (fantasyland#191) test: remove unnecessary lambdas (fantasyland#190) require static methods to be defined on type representatives (fantasyland#180) lint: integrate ESLint (fantasyland#189) Enforce parametricity (fantasyland#184) readme: tweak signatures to indicate that methods are not curried (fantasyland#183) Fix reduce signature to not use currying (fantasyland#182) Link to dependent specifications (fantasyland#178) Add Fluture to the list of implementations (fantasyland#175) laws/functor: fix composition (fantasyland#173) laws/monad: fix leftIdentity (fantasyland#171) Minor version bump bower: add bower.json (fantasyland#159) Fix chainRec signature to not use currying (fantasyland#167) ...

Convert from mp to dot

7b465f1

joneshf mentioned this pull request Oct 23, 2016

update dependency graph #160

Closed

rjmk reviewed Oct 23, 2016

View reviewed changes

davidchambers reviewed Oct 23, 2016

View reviewed changes

joneshf added 2 commits October 23, 2016 04:54

Use the svg only

63016be

Committed wrong url...

1b0208d

davidchambers reviewed Oct 23, 2016

View reviewed changes

joneshf added 3 commits October 23, 2016 05:08

Also remove png creation from script

531b881

Use GitHub's link color

58647bd

Use sha

4c1e3ee

joneshf added 2 commits October 23, 2016 05:56

Don't use hrefs

6900fb8

Update dependency svg sha

1ee2e5d

joneshf added 2 commits October 23, 2016 06:36

Just use png instead of svg

dca905c

Update width and height

c840121

joneshf merged commit 2a94dce into fantasyland:master Oct 23, 2016

joneshf deleted the dependencies branch October 23, 2016 14:34

davidchambers mentioned this pull request Dec 16, 2016

update Extend and Comonad dependencies to match figure #213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Another go at updating dependencies #192

Another go at updating dependencies #192

joneshf commented Oct 23, 2016

rjmk Oct 23, 2016

joneshf Oct 23, 2016

davidchambers Oct 23, 2016

davidchambers Oct 23, 2016

davidchambers Oct 23, 2016

davidchambers Oct 23, 2016

joneshf Oct 23, 2016

davidchambers Oct 23, 2016

joneshf Oct 23, 2016

davidchambers Oct 23, 2016

joneshf Oct 23, 2016

davidchambers Oct 23, 2016

davidchambers Oct 23, 2016

joneshf Oct 23, 2016

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

davidchambers commented Oct 23, 2016

SimonRichardson commented Oct 23, 2016

		@@ -0,0 +1,35 @@
		digraph {
		node [fontcolor=blue;shape=plaintext]

		@@ -25,7 +25,7 @@ structures:
		* [Bifunctor](#bifunctor)
		* [Profunctor](#profunctor)

Another go at updating dependencies #192

Another go at updating dependencies #192

Conversation

joneshf commented Oct 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

joneshf commented Oct 23, 2016

davidchambers commented Oct 23, 2016

davidchambers commented Oct 23, 2016

SimonRichardson commented Oct 23, 2016