Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a contravariant functor to spec #16

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Conversation

rjmk
Copy link
Contributor

@rjmk rjmk commented Aug 21, 2016

@coveralls
Copy link

Coverage Status

Coverage remained the same at 31.667% when pulling 3591965 on rjmk:master into 1850c6c on rpominov:master.

@rpominov
Copy link
Member

Thanks! Let's see how fantasyland/fantasy-land#150 go.

@rjmk
Copy link
Contributor Author

rjmk commented Aug 21, 2016

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 31.667% when pulling 7482b25 on rjmk:master into 1850c6c on rpominov:master.

@rjmk
Copy link
Contributor Author

rjmk commented Feb 3, 2017

Still interested in this now it's merged in FL? If so, I'll spend some time getting it up to date

@rpominov
Copy link
Member

rpominov commented Feb 3, 2017

Yea, definitely interested. Please do!

@rjmk
Copy link
Contributor Author

rjmk commented Feb 16, 2017

I appear to have stolen your profile picture, @rpominov. Sorry about that

I think this is updated! No diagram (my arch nemesis in FL PRs)

@rpominov
Copy link
Member

Thank you! I'll take a close look tomorrow and hopefully merge.

I appear to have stolen your profile picture, @rpominov. Sorry about that

Haha, not quite the same though 😅

docs/spec.md Outdated

#### Methods

1. `contramap :: Contravariant f => (a → b, f b) → f a`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be contramap :: Contravariant f => Type f ~> (a → b, f b) → f a.

This notations probably doesn't make much sense to anyone but me, and I don't like it too much either. But for now we should use it in all methods for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@rpominov rpominov merged commit c86a266 into fantasyland:master Feb 22, 2017
@rpominov
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants