2020-09-09 去掉方法签名上不必要的异常

fanyong920 · Sep 9, 2020 · 1ff74c8 · 1ff74c8
1 parent fdfdbb7
commit 1ff74c8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -35,7 +35,7 @@
 <dependency>
   <groupId>io.github.fanyong920</groupId>
   <artifactId>jvppeteer</artifactId>
-  <version>1.0.7</version>
+  <version>1.0.8</version>
 </dependency>
 ```
 
@@ -50,7 +50,7 @@ mavenCentral（）
 然后，您可以将最新版本添加到您的构建中。
 
 ```xml
-compile "io.github.fanyong920:jvppeteer:1.0.7"
+compile "io.github.fanyong920:jvppeteer:1.0.8"
 ```
 
 #### Logging

diff --git a/pom.xml b/pom.xml
@@ -241,7 +241,6 @@
             </plugins>
         </pluginManagement>
         <sourceDirectory>src/main/java</sourceDirectory>
-        <testSourceDirectory>src/test/java</testSourceDirectory>
         <plugins>
             <plugin>
                 <groupId>biz.aQute.bnd</groupId>

diff --git a/src/main/java/com/ruiyun/jvppeteer/core/page/DOMWorld.java b/src/main/java/com/ruiyun/jvppeteer/core/page/DOMWorld.java
@@ -329,7 +329,7 @@ private String addStyleUrl() {
                 "    }";
     }
 
-    public void click(String selector, ClickOptions options,boolean isBlock) throws InterruptedException, ExecutionException {
+    public void click(String selector, ClickOptions options,boolean isBlock) throws InterruptedException {
         ElementHandle handle = this.$(selector);
         ValidateUtil.assertArg(handle != null, "No node found for selector: " + selector);
         if(isBlock){

diff --git a/src/main/java/com/ruiyun/jvppeteer/core/page/ElementHandle.java b/src/main/java/com/ruiyun/jvppeteer/core/page/ElementHandle.java
@@ -327,7 +327,7 @@ public void click(boolean isBlock) throws InterruptedException, ExecutionExcepti
         click(new ClickOptions(),isBlock);
     }
 
-    public void click(ClickOptions options,boolean isBlock) throws InterruptedException, ExecutionException {
+    public void click(ClickOptions options,boolean isBlock) throws InterruptedException {
         this.scrollIntoViewIfNeeded();
         ClickablePoint point = this.clickablePoint();
         if(!isBlock){

diff --git a/src/main/java/com/ruiyun/jvppeteer/core/page/ExecutionContext.java b/src/main/java/com/ruiyun/jvppeteer/core/page/ExecutionContext.java
@@ -100,11 +100,7 @@ private Object evaluateInternal(boolean returnByValue, String pageFunction, Page
         List<Object> argList = new ArrayList<>();
         if (ValidateUtil.isNotEmpty(args)) {
             for (Object arg : args) {
-                try {
-                    argList.add(convertArgument(this, arg));
-                } catch (JsonProcessingException e) {
-                    throw new RuntimeException(e);
-                }
+                argList.add(convertArgument(this, arg));
             }
         }
         params.put("functionDeclaration", functionText + "\n" + suffix + "\n");
@@ -150,7 +146,7 @@ public JSHandle queryObjects(JSHandle prototypeHandle) {
         }
     }
 
-    public Object convertArgument(ExecutionContext th, Object arg) throws JsonProcessingException {
+    public Object convertArgument(ExecutionContext th, Object arg) {
         ObjectNode objectNode = Constant.OBJECTMAPPER.createObjectNode();
         if (arg == null) {
             return null;