Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update legacy browser warning #1865

Merged
merged 1 commit into from
Apr 4, 2024
Merged

docs: Update legacy browser warning #1865

merged 1 commit into from
Apr 4, 2024

Conversation

dawsbot
Copy link
Contributor

@dawsbot dawsbot commented Apr 4, 2024

Motivation

Browser support was added via #573 but this documentation was not updated to reflex those changes

Change Summary

See above ^

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating the README.md file in the hub-nodejs package. It includes changes related to error handling, required packages, and support for both Nodejs and browser environments.

Detailed summary

  • Updated support information for Nodejs and browser environments.
  • Improved error handling with a monadic pattern.
  • Clarified the required packages for creating new messages.
  • Encoded fixed length data in byte formats for consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: c2eeff8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 4:33pm

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.49%. Comparing base (1880070) to head (c2eeff8).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1865       +/-   ##
===========================================
- Coverage   74.05%   36.49%   -37.57%     
===========================================
  Files          99      122       +23     
  Lines        9425    20633    +11208     
  Branches     2097     7128     +5031     
===========================================
+ Hits         6980     7529      +549     
- Misses       2327    11170     +8843     
- Partials      118     1934     +1816     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adityapk00 adityapk00 merged commit fa6812b into farcasterxyz:main Apr 4, 2024
9 of 10 checks passed
@dawsbot dawsbot deleted the patch-1 branch April 5, 2024 04:14
@dawsbot
Copy link
Contributor Author

dawsbot commented Apr 5, 2024

Thanks @adityapk00! Honored to have my first commit merged 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants