-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor protobufs and utils to remove grpc-js dependency #798
Changes from 11 commits
29f423c
efc483b
142d226
511ef02
7e9e274
acf3f5a
494a116
92c0c0e
7810d91
aed6683
a043e15
f95eed5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@farcaster/protobufs': minor | ||
'@farcaster/hub-web': minor | ||
'@farcaster/utils': minor | ||
'@farcaster/hub-nodejs': patch | ||
'@farcaster/hubble': patch | ||
--- | ||
|
||
remove grpc-js dependency from protobufs, refactor hubble to use hub-nodejs | ||
hub-web to use @farcaster/protobufs and utils |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,8 +47,7 @@ | |
"dependencies": { | ||
"@chainsafe/libp2p-gossipsub": "6.1.0", | ||
"@chainsafe/libp2p-noise": "^11.0.0 ", | ||
"@farcaster/protobufs": "0.1.11", | ||
"@farcaster/utils": "0.4.0", | ||
"@farcaster/hub-nodejs": "^0.6.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the process for package release here? We need to release and update dependency to new version in order: Do we need to break this PR into multiple PRs for release purpose? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use changesets for version control, so we can run |
||
"@grpc/grpc-js": "~1.8.7", | ||
"@libp2p/interface-connection": "^3.0.2", | ||
"@libp2p/interface-peer-id": "^2.0.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import * as protobufs from '@farcaster/protobufs'; | ||
import { Factories } from '@farcaster/utils'; | ||
import * as hub_nodejs from '@farcaster/hub-nodejs'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: can you camelCase this variable? |
||
import { Factories } from '@farcaster/hub-nodejs'; | ||
import { ConsoleCommandInterface } from './console'; | ||
|
||
export class ProtobufCommand implements ConsoleCommandInterface { | ||
|
@@ -18,7 +18,7 @@ export class ProtobufCommand implements ConsoleCommandInterface { | |
`; | ||
} | ||
object() { | ||
return protobufs; | ||
return hub_nodejs; | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally it's major change for protobufs and utils (interface not backward compatible). However, it seems that we haven't released major version of protobufs & utils yet, so I made it minor.