Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor protobufs and utils to remove grpc-js dependency #802

Closed
wants to merge 11 commits into from

Conversation

PangZhi
Copy link
Contributor

@PangZhi PangZhi commented Apr 4, 2023

Motivation

Part of #573, removed grpc-js dependency from protobufs (thus utils).

Change Summary

  • separate rpc.proto to request_response.proto and rpc.proto (only have service definition), remove grpc-js dependency from protobufs (thus utils)
  • move all grpc-js code generation to hub-nodejs
  • refactor hubble app to use hub-nodejs
  • add protobufs & utils as dependency for hub-web and add new exports

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR does not require changes to the protocol

Additional Context

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: a043e15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@farcaster/protobufs Minor
@farcaster/hub-web Minor
@farcaster/utils Minor
@farcaster/hub-nodejs Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Apr 4, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@farcaster/[email protected] None +1 varunsrin
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@grpc/[email protected] 1.8.7...1.8.13 None +0/-0 murgatroid99

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 85.58% and project coverage change: -0.56 ⚠️

Comparison is base (71d6494) 73.03% compared to head (a043e15) 72.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   73.03%   72.48%   -0.56%     
==========================================
  Files          61       62       +1     
  Lines        5359     5379      +20     
  Branches     1216     1212       -4     
==========================================
- Hits         3914     3899      -15     
- Misses       1351     1380      +29     
- Partials       94      100       +6     
Impacted Files Coverage Δ
apps/hubble/src/eth/utils.ts 100.00% <ø> (ø)
apps/hubble/src/hubble.ts 1.86% <0.00%> (ø)
apps/hubble/src/network/p2p/protocol.ts 100.00% <ø> (ø)
apps/hubble/src/rpc/adminServer.ts 1.88% <0.00%> (ø)
apps/hubble/src/rpc/server.ts 79.24% <ø> (ø)
apps/hubble/src/storage/db/hubState.ts 36.36% <ø> (ø)
apps/hubble/src/storage/db/idRegistryEvent.ts 83.87% <ø> (ø)
apps/hubble/src/storage/db/nameRegistryEvent.ts 100.00% <ø> (ø)
apps/hubble/src/storage/db/rocksdb.ts 90.47% <ø> (ø)
apps/hubble/src/storage/engine/seed.ts 100.00% <ø> (ø)
... and 27 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PangZhi PangZhi force-pushed the jf/refactor_protobufs_utils branch from 9af4c4a to 7810d91 Compare April 4, 2023 04:13
@PangZhi PangZhi closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants