-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrap hub-web client to provide consistent APIs with hub-nodejs #811
Conversation
🦋 Changeset detectedLatest commit: e95e1a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the client exported methods, otherwise looks good!
packages/hub-web/src/client.ts
Outdated
|
||
export type RpcWebClient = WrappedClient<HubService>; | ||
|
||
export const getRpcWebClient = (url: string, isBrowser = true): WrappedClient<HubService> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we export getSSLHubRpcClient
and getInsecureHubRpcClient
to be consistent with hub-nodejs?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 73.03% 72.59% -0.45%
==========================================
Files 61 63 +2
Lines 5359 5429 +70
Branches 1216 1220 +4
==========================================
+ Hits 3914 3941 +27
- Misses 1351 1386 +35
- Partials 94 102 +8
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Motivation
As part #573, wrap client of hub-web so APIs are consistent with hub-nodejs. This will provide better developer experience.
Change Summary
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context