Porting to the Buffer.from()/Buffer.alloc() #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The propose of this PR is to move from deprecated and unsafe Buffer() and new Buffer() constructors to safer Buffer.from()/Buffer.alloc().
In order to keep support for Node versions <6, safer-buffer polyfill was added. safer-buffer was already a dependency from iconv-lite.
The guidelines used for these changes are described Node porting guide Variant 1 and Variant 2
Later, when old Node versions support is no longer required or not possible to support, all that is required is to remove the safer-buffer polyfill and dependency.
Changes where tested with and without polyfill.