Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin_resolve): duplicated querystring on external #2057

Merged
merged 3 commits into from
Jan 11, 2025
Merged

fix(plugin_resolve): duplicated querystring on external #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d42b1c7
fix(plugin_resolve): duplicated querystring on external
HelloWorld017 Jan 9, 2025
b9eec4d
chore: add changeset
HelloWorld017 Jan 9, 2025
9668d22
Merge branch 'main' into fix/external-with-querystring
wre232114 Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-berries-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farmfe/core": patch
---

Fix query strings in external imports are duplicated
2 changes: 1 addition & 1 deletion crates/plugin_resolve/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl Plugin for FarmPluginResolve {
// check external first, if the source is set as external, return it immediately
if external_config.is_external(source) {
return Ok(Some(PluginResolveHookResult {
resolved_path: param.source.clone(),
resolved_path: String::from(source),
wre232114 marked this conversation as resolved.
Show resolved Hide resolved
external: true,
side_effects: false,
query,
Expand Down
Loading