Skip to content

Commit

Permalink
Merge pull request #46 from farmersdog/antonbeza/success-without-link…
Browse files Browse the repository at this point in the history
…ed-story

Currently builds fail if no Shortcut story is referenced in the branch name or PR title. 

This PR makes it so the build still passes even if no Shortcut story ID is found in the branch name or PR title.

### Changes
* Makes it so the PR title stays as-is if no Shortcut stories are referenced and passes the build
* Added some JSDocs
* Removed `getShortcutStory` function since it wasn't adding anything useful over the raw Shortcut client call

### Testing
* Wrote a medium sized test to confirm the core behavior
* Mocked the Shortcut client
* Manually tested that fetching from Shortcut worked using the included `createTitle.js` script
  • Loading branch information
antontfd authored Dec 20, 2022
2 parents 5ed2f25 + eedafd0 commit 4aae70f
Show file tree
Hide file tree
Showing 6 changed files with 20,680 additions and 2,680 deletions.
Loading

0 comments on commit 4aae70f

Please sign in to comment.