Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩺 Take the GH badge only from pushes to the main branch #1291

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Feb 7, 2025

Ensure that the "Test" badge on https://sqlmodel.tiangolo.com/ and https://github.com/fastapi/sqlmodel/blob/main/README.md only looks at the latest push to main (similar to how it's currently done in FastAPI).

@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 7, 2025
@svlandeg svlandeg marked this pull request as draft February 7, 2025 16:14
@svlandeg svlandeg self-assigned this Feb 7, 2025
Copy link

📝 Docs preview for commit 95009f5 at: https://88871a5d.sqlmodel.pages.dev

Modified Pages

Copy link
Member Author

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready, but the test suite needs to fixed first: #1290

[UPDATE: test suite OK again]

@svlandeg svlandeg assigned svlandeg and unassigned svlandeg Feb 10, 2025
Copy link

📝 Docs preview for commit ce109d5 at: https://c5275cf8.sqlmodel.pages.dev

Modified Pages

@svlandeg svlandeg marked this pull request as ready for review February 20, 2025 10:43
@svlandeg svlandeg removed their assignment Feb 20, 2025
Copy link

📝 Docs preview for commit f197141 at: https://ff9ffb02.sqlmodel.pages.dev

Modified Pages

Copy link

📝 Docs preview for commit bae1679 at: https://35982fe9.sqlmodel.pages.dev

Modified Pages

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! 🍰

@tiangolo tiangolo merged commit b3e0f1c into fastapi:main Feb 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants