Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix CI test suite for Windows and MacOS #1307

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
+5 −4
Draft

💚 Fix CI test suite for Windows and MacOS #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6343647
fix test to be ready for Windows
svlandeg Feb 21, 2025
f9465b2
put os into the matrix
svlandeg Feb 21, 2025
adca0b0
test with 3 os's
svlandeg Feb 21, 2025
94d8cf3
Add OS version to coverage file name to avoid duplicates
svlandeg Feb 21, 2025
86ab165
only test on ubuntu
svlandeg Feb 21, 2025
68ee41f
also test on macos-latest
svlandeg Feb 21, 2025
b75acf9
only test on macos-latest
svlandeg Feb 21, 2025
e67f194
user runner.os instead
svlandeg Feb 21, 2025
36595bf
Merge branch 'main' into feat/ci_again
svlandeg Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
test:
strategy:
matrix:
os: [ ubuntu-latest ]
os: [ macos-latest ]
python-version:
- "3.8"
- "3.9"
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Store coverage files
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
name: coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.pydantic-version }}
path: coverage
include-hidden-files: true

Expand Down
5 changes: 3 additions & 2 deletions tests/test_select_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import subprocess
import sys
from pathlib import Path
Expand All @@ -10,8 +11,8 @@
@needs_py39
def test_select_gen() -> None:
result = subprocess.run(
[sys.executable, "scripts/generate_select.py"],
env={"CHECK_JINJA": "1"},
[sys.executable, Path("scripts") / "generate_select.py"],
env={**os.environ, "CHECK_JINJA": "1"},
check=True,
cwd=root_path,
capture_output=True,
Expand Down
Loading