Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #323: Always accept local changes to resolve merge conflicts #325

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Jan 7, 2025

Cc: @mpage

@mdboom mdboom requested a review from Copilot January 7, 2025 20:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comment on lines 236 to 237
git stash
git cherry-pick -n -m1 -Xtheirs stash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to pull here and below?

Suggested change
git stash
git cherry-pick -n -m1 -Xtheirs stash
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash

Comment on lines 332 to 333
git stash
git cherry-pick -n -m1 -Xtheirs stash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git stash
git cherry-pick -n -m1 -Xtheirs stash
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash

@mdboom mdboom requested review from Copilot and mpage January 8, 2025 15:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

bench_runner/templates/_benchmark.src.yml:335

  • The use of 'git cherry-pick -n -m1 -Xtheirs stash' is unusual and may not work as intended. Consider using 'git stash pop' or 'git stash apply' instead.
git cherry-pick -n -m1 -Xtheirs stash

# https://stackoverflow.com/questions/43770520/how-to-specify-default-merge-strategy-on-git-stash-pop
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash
Copy link
Preview

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'git cherry-pick -n -m1 -Xtheirs stash' is unusual and may not work as intended. Consider using 'git stash pop' or 'git stash apply' instead.

Suggested change
git cherry-pick -n -m1 -Xtheirs stash
git stash pop

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
# https://stackoverflow.com/questions/43770520/how-to-specify-default-merge-strategy-on-git-stash-pop
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash
Copy link
Preview

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'git cherry-pick -n -m1 -Xtheirs stash' is unusual and may not work as intended. Consider using 'git stash pop' or 'git stash apply' instead.

Suggested change
git cherry-pick -n -m1 -Xtheirs stash
git stash pop

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdboom mdboom merged commit 21d3626 into main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants